Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication and custom intercept support. #50

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Dec 30, 2022

  1. Add GrpcReporter::authentication method.
  2. Add GrpcReporter::with_custom_intercept method.
  3. Adjust the logic to suit the changes.

@jmjoy jmjoy added the enhancement New feature or request label Dec 30, 2022
@jmjoy jmjoy added this to the 0.5.0 milestone Dec 30, 2022
@jmjoy jmjoy self-assigned this Dec 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #50 (21b9f2a) into master (4c61a5b) will decrease coverage by 3.86%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   21.40%   17.54%   -3.87%     
==========================================
  Files          20       17       -3     
  Lines         612      570      -42     
==========================================
- Hits          131      100      -31     
+ Misses        481      470      -11     
Impacted Files Coverage Δ
src/reporter/grpc.rs 0.00% <0.00%> (ø)
src/skywalking_proto/v3/mod.rs 0.00% <ø> (ø)
src/trace/span.rs 0.00% <0.00%> (ø)
tests/propagation.rs
tests/management.rs
tests/trace_context.rs

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wu-sheng
Copy link
Member

Please update docs about these new features.

Comment on lines +147 to +148
// Optional authentication, based on backend setting.
let reporter = reporter.with_authentication("<TOKEN>");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wu-sheng The authentication feature is described in the example.

@jmjoy jmjoy marked this pull request as ready for review January 3, 2023 03:41
@wu-sheng wu-sheng merged commit cbf1079 into apache:master Jan 3, 2023
@jmjoy jmjoy deleted the auth branch January 3, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants