-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stream and completed for a bulk to collect for grpc reporter. #54
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 17.51% 17.18% -0.34%
==========================================
Files 17 17
Lines 571 582 +11
==========================================
Hits 100 100
- Misses 471 482 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is this a gRPC stream? If so, gRPC stream should be completed for a bulk. Keeping a stream always open may have side effect, and cause too much load to maintain the uncompleted status. |
OK, will adjust. |
Ref this. If you are going to implement |
I want to adjust it as follows: Every 30 seconds, the stream will end, and then |
You could control it according to rust implementation. Just keep it neither always open, nor keep open/close for every segment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the past, for convenience,
collect
was called every time the data was received.Now it is changed to stream mode, and only call
collect
once, which should improve the performance.