Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AbstractSpan to HandleSpanObject. #62

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 11, 2023

Because Rust does not support inheritance, it is a bit strange to name the trait AbstractSpan, but it is more pleasing to name it as a verb.

@jmjoy jmjoy added this to the 0.8.0 milestone Jul 11, 2023
@jmjoy jmjoy requested review from heyanlong and wu-sheng July 12, 2023 02:07
@wu-sheng wu-sheng merged commit afa5cdb into apache:master Jul 12, 2023
@jmjoy jmjoy deleted the span branch July 12, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants