-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Nacos cluster #2640
support Nacos cluster #2640
Conversation
…/sky-walking into fix/spring-plugin-issue
Fix/spring plugin issue
Please check Nacos license issue first, then we could talk about this PR. |
the check result: five jars added, no jar's version update.
|
i have updated the license, plz review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SkyWalking dist LICENSE file has not been updated.
- Nacos lib should be included here, https://github.com/apache/skywalking/blob/master/apm-dist/release-docs/LICENSE#L310
- Fastjson lib should be included here, https://github.com/apache/skywalking/blob/master/apm-dist/release-docs/LICENSE#L220
apm-dist/release-docs/NOTICE
Outdated
|
||
=========================================================================== | ||
fastjson-1.2.47 Notice | ||
=========================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastjson notice should be removed. It doesn't include more things than its license file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@peng-yongsheng Please recheck the document/LICENSE first, the new Nacos version with the exclusions should be good. |
Hi @IanCao, can you help me to correct some mistakes about not clear dependency management. I checked the dependency tree. And I found those third-party libraries are not managed by the OAP module's dependency manager, etc.. jackson-core, jackson-annotations, jackson-databind, commons-codec, commons-lang3. |
@peng-yongsheng could we change those through different pull request? Look like irrelevant. |
From this compile dependencies list, his exclude list is right and the third-party library's licenses are no problem. @wu-sheng |
Those third-party libraries are using by gPRC and zookepper, but with different version. I'm not sure the OAP server is work well after the version changed. |
@wu-sheng I think keeping those third-party libraries version is the best solution. He can only test the nacos client without test the whole OAP server. So, he can find the version number from current master source then put them into the dependency management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for dependency management.
@peng-yongsheng I am just suggesting, we could try to work on another pull request to make sure the dependency clear for current master, then we update this pr. |
ok, i'll make the dependency management more clear and open a new pr to fix |
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement