Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manipulating-content-the-slingpostservlet-servlets-post.md #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update manipulating-content-the-slingpostservlet-servlets-post.md #2

wants to merge 1 commit into from

Conversation

gauravs23
Copy link

Update node name and node type generation algorithm description in case of File Uploads using SlingPostServlet

@gauravs23
Update manipulating-content-the-slingpostservlet-servlets-post.md
a4cbdeb 
Update node name and node type generation algorithm description in case of File Uploads using SlingPostServlet
rombert
rombert approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me overall. @bdelacretaz - maybe you can take a look as you probably know this better?

@bdelacretaz
Copy link
Member

The proposed changes look good to me in principle, thank you very much!
But do we have tests of those features? I don't remember the details off the top of my head and I'd like to make sure those details are correct. Or maybe have less details in the docs and point to those tests for the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rombert rombert rombert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gauravs23 @bdelacretaz @rombert