Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download binaries (incl. hashes and signatures) from ASF Maven #55

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwin
Copy link
Member

@kwin kwin commented Feb 24, 2021

Repository

@bdelacretaz
Copy link
Member

Why? My understanding is that this would prevent using the ASF mirrors for downloads.

@kwin
Copy link
Member Author

kwin commented Feb 24, 2021

See https://lists.apache.org/thread.html/r5ac69fcb1251aaad4b5c6e69e4784369c74bee0d13e3ffeb990e3e64%40%3Cdev.sling.apache.org%3E for a background. I don't think that a lot of people are downloading Sling Modules with other means than via Maven (with all its mirrors).

@bdelacretaz
Copy link
Member

Ok, I have commented on our dev list - I ask that you do not merge this PR for now, while we discuss there. I think it's good to use the ASF mirrors for all downloads and as mentioned there I don't really see the problem with svn.

@@ -324,6 +324,19 @@ def downloadLink(label, artifact, version, suffix) {
newLine()
}

def mavenDownloadLink(label, artifact, version, suffix) {
def path = "${artifact}/${version}/${artifact}-${version}${suffix}"
def base = "https://repository.apache.org/content/repositories/releases/org/apache/sling/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to point to Maven Central instead

Projects must not point or refer to repository.apache.org directly in download pages, release announcements or emails. Instead, any public download links for those releases should point to Maven Central.

(https://infra.apache.org/release-distribution.html#maven)

@kwin kwin marked this pull request as draft February 25, 2021 08:59
@rombert rombert removed their request for review December 16, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants