Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS with recent Solr 9.x versions #610

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented Aug 24, 2023

Resolves #609

This is a WIP

There are various things that Solr 9.4+ will help with, but we need to support 8.11 at the very least.

Therefore, this is a part of #616

Basically we need to:

  • Make sure the hostname for the Solr API is always correct
  • Use the solr api command instead of invoking SolrCLI explicitly
  • Mention SOLR_TOOL_OPTS in the future Solr version usages, and find a workaround for 8.11/9.3
  • Changelog entry
  • Upgrade Notes
  • Supported Versions matrix

@HoustonPutman HoustonPutman marked this pull request as draft August 24, 2023 18:34
@HoustonPutman HoustonPutman changed the title WIP - work on probes and 9.x support for TLS Support TLS with recent Solr 9.x versions Aug 24, 2023
@HoustonPutman
Copy link
Contributor Author

Thanks to SOLR-16964, Solr 9.4 will come with the correct SNI hostCheck default given the value of CheckPeerName. Because of this, and the fact that we only really will support SSL for 9.4+, we don't need to set this value. (And it isn't an issue in 8.11, so 8.11 and 9.4+ will work without this setting).

@HoustonPutman HoustonPutman marked this pull request as ready for review September 19, 2023 19:44
@HoustonPutman HoustonPutman merged commit 696faff into apache:main Sep 19, 2023
@HoustonPutman HoustonPutman deleted the tls-probes-fix branch September 19, 2023 20:13
@sarkaramrit2
Copy link

Thank you @HoustonPutman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Solr probes w/TLS for Solr 9.2+
2 participants