Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return metrics for liveness probe #694

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Do not return metrics for liveness probe #694

merged 3 commits into from
Mar 26, 2024

Conversation

HoustonPutman
Copy link
Contributor

Fixes #693

@HoustonPutman
Copy link
Contributor Author

For some reason, in the 8.11 branch the /-/healthy endpoint still returns all metrics, so that doesn't fix this issue. Once we upgrade to 9x being the minimum supported version, then we can switch to healthy instead of just requesting no metrics.

gerlowskija
gerlowskija approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HoustonPutman HoustonPutman merged commit 2358d54 into apache:main Mar 26, 2024
3 checks passed
@HoustonPutman HoustonPutman deleted the metrics-probe branch March 26, 2024 20:16
HoustonPutman added a commit that referenced this pull request Apr 3, 2024
@HoustonPutman
Do not return metrics for liveness probe (#694)
73cffd0 
Fixes #693
smoldenhauer-ish added a commit to intershop/solr-operator that referenced this pull request Nov 15, 2024
@smoldenhauer-ish
fix: do not return metrics for prom-exporter probes re-fix (apache#694)
c613dad
@smoldenhauer-ish smoldenhauer-ish mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerlowskija gerlowskija gerlowskija approved these changes

@janhoy janhoy Awaiting requested review from janhoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liveness probe failing for Prometheus Exporter connected to a large SolrCloud
2 participants
@HoustonPutman @gerlowskija