sync map based on review comments

apache · Nov 18, 2024 · 4589687 · 4589687
1 parent 216180c
commit 4589687
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/solr/modules/llm/src/java/org/apache/solr/llm/store/EmbeddingModelStore.java b/solr/modules/llm/src/java/org/apache/solr/llm/store/EmbeddingModelStore.java
@@ -28,10 +28,10 @@ public class EmbeddingModelStore {
   private final Map<String, SolrEmbeddingModel> availableModels;
 
   public EmbeddingModelStore() {
-    availableModels = new LinkedHashMap<>();
+    availableModels = Collections.synchronizedMap(new LinkedHashMap<>());
   }
 
-  public synchronized SolrEmbeddingModel getModel(String name) {
+  public SolrEmbeddingModel getModel(String name) {
     return availableModels.get(name);
   }
 
@@ -54,7 +54,7 @@ public SolrEmbeddingModel delete(String modelName) {
     return availableModels.remove(modelName);
   }
 
-  public synchronized void addModel(SolrEmbeddingModel modeldata) throws EmbeddingModelException {
+  public void addModel(SolrEmbeddingModel modeldata) throws EmbeddingModelException {
     final String name = modeldata.getName();
     if (availableModels.containsKey(name)) {
       throw new EmbeddingModelException(