-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16562 / SOLR-16578: Upgrade caffeine to 3.1.4 and errorprone to 2.18.0 #1380
SOLR-16562 / SOLR-16578: Upgrade caffeine to 3.1.4 and errorprone to 2.18.0 #1380
Conversation
86ed447
to
37c9f7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs a closer look. This ends up being a relatively bigger change due to changes to how caffeine fixed their transitive dependencies. https://issues.apache.org/jira/browse/SOLR-16562 has some details and #1198 (comment)
I wonder why this didn't go directly to 3.1.4? - https://github.com/ben-manes/caffeine/releases/tag/v3.1.4 |
3.1.4 was released 4 days and we use a 5 day delay, so it will likely be updated tomorrow. You see it in the “pending” column of the table above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changed dependencies. The only one that we currently manage in versions.props
is errorprone and so need to update versions.props
with com.google.errorprone:*=2.18
.
@janhoy Can we add a [renovatebot] to the PR title, please? I think dependabot used to do that. Edit: oops, dependabot didn't do that. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
We can customize title, but I’d instead like to add label “dependencies” on all these. Requires Solr bot to have “triage” karma, but that’s easily done in asf.yaml |
X-ref #1400 - which will be auto closed once this is merged. |
Found existing JIRA https://issues.apache.org/jira/browse/SOLR-16562 for 9.2, so I tagged title and bumped CHANGES |
Added changes to SOLR-16578 for errorprone since might as well fix that entry too. |
…2.18.0 (#1380) Co-authored-by: Kevin Risden <krisden@apache.org> Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
This PR contains the following updates:
3.1.2
->3.1.3
3.1.4
Release Notes
ben-manes/caffeine
v3.1.3
: 3.1.3Cache
JCache
putAll
with an immutable map that causes an exception when using a cache writer (#841)Configuration
📅 Schedule: Branch creation - "* 8-20 * * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot