SOLR-16390: Tweak clusterprop APIs to be more REST-ful #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes some cosmetic changes to these APIs to bring them a bit more into line with the REST-ful design we're aiming for going forward. Still needed for this PR: - removal of the old '@endpoint'-based v2 clusterprop APIs - tidy, check, test, etc. It's worth noting that this PR mostly only aims at parity with existing functionality: There are a few other improvements that we _don't_ attempt to solve. Particularly: - it's tough to update anything but top-level property names using the single-prop-update API - Tough to fetch anything other than top-level properties. - explicit 'null' for deletion is still allowed (Should be remove in favor of the DELETE API this PR adds)
|
Currently still TODO:
|
|
Superceded by #2788; closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16390
Description
Solr has slowly been modifying its v2 APIs to align around a more REST-ful model. Many APIs have already been through this re-alignment but many more remain, including a handful of "collection-admin" APIs.
Solution
This PR chips away at this gap by tweaking Solr's "clusterprop" APIs to be more REST-ful:
PUT /api/cluster/properties/propName {...}PUT /api/cluster/properties {...}DELETE /api/cluster/properties/propNameTests
TODO
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.