Don't create a Thread when there is no thread #2514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Jira.
This is just to clean-up a bad smell in the code.
Description
We create a
java.lang.Thread
instance, but this thread is never started. It just acts as a target for another existing thread, from the executor pool. The call tosetDaemon()
has no effect.This code was reported by errorprone because of the thread creation without a name (hence the removed
@SuppressForbidden
)Replacing the thread by a Runnable makes the full thing cleaner.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.