SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… home. Only -e cloud generates it's individual node files in ./example/cloud/node1, node2 etc...
github-actions
bot
added
documentation
HoustonPutman
approved these changes
Nov 12, 2024
|
I think stripping out the |
|
I mean, this is just changing the examples. I think we can back port this. People should not be using the tech products config in production. |
gerlowskija
reviewed
Nov 19, 2024
solr/CHANGES.txt
Outdated
| @@ -237,6 +237,9 @@ led to the suppression of exceptions. (Andrey Bozhko) | |||
|
|
|||
| * SOLR-17545: Upgrade to Gradle 8.10 (Houston Putman) | |||
|
|
|||
| * SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir (except for | |||
There was a problem hiding this comment.
[0] Minor nit - the "should" here might confuse users. Is this how Solr behaves in 9.8? Is it how it should behave? etc.
Wording like "home" and "data" directories used by Solr examples have been updated to align with documented best practices. might be a little clearer.
|
Feedback in corporated. When this is back ported we need to remember to remove the CREDENTIALS lookups ;-) |
7 tasks
epugh
added a commit
that referenced
this pull request
Nov 22, 2024
…home and solr data dir (#2861) * Have techproducts, films, and schemaless all start in the normal solr home. Only -e cloud generates it's individual node files in ./example/cloud/node1, node2 etc... * Update the ref guide to consistently use -Dsolr.modules settings instead of relying on on the <lib/> declaration. --------- Co-authored-by: Houston Putman <houston@apache.org> (cherry picked from commit 620175a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17556
Description
Except for -e cloud, all the other examples just store their data and configs as if you did just a normal
bin/solr startand then created them by hand!Solution
Remove some use of exampledir
Tests
Unit and manual testing