SOLR-16427: Enable error-prone PatternMatchingInstanceof rule #2867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16427
Description
With the new errorprone rules and starting from 16+ we can use pattern-matching for
instanceof
.Solution
This PR enables
PatternMatchingInstanceof
and applies auto-refactoring from IntelliJ for pattern-matching cases.Note that these changes are not backwards compatible (branch_9x) as the refactored code makes use of a JDK 16 feature.
Tests
No tests were added or removed. Tests with pattern-matching improvements were refactored accordingly.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.