SOLR-16165: Rare deadlock in SlotAcc initialization #819
Conversation
|
Another alternative would be to just move I thought about it. But, this is a general constant and could be used elsewhere as well |
| * This CountSlotAcc exists as a /dev/null sink for callers of collect(...) and other "write"-type | ||
| * methods. It should be used in contexts where "read"-type access methods will never be called. | ||
| */ | ||
| private static class DevNullCountSlotAcc extends SlotAcc.CountSlotAcc { |
There was a problem hiding this comment.
Too late (already merged) but I think "NoOp" would be a more meaningful name than a reference to this Unix mechanism that isn't really 1-for-1 with what we have here. If this were an OutputStream to no-where, I'd think DevNull is perfect :-)
There was a problem hiding this comment.
Makes sense, thanks for calling this out. (extra context: the naming was merged long ago, with SOLR-13132).
There was a problem hiding this comment.
Yeah, this DevNull is kinda lame. Anyway , this is a private class and we can change it if needed
copied from fullstorydev/lucene-solr#140