add comment

apache · Mar 28, 2017 · 4739c0b · 4739c0b
1 parent d3a174a
commit 4739c0b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
@@ -90,7 +90,10 @@ trait PredicateHelper {
    * Returns true iff `expr` could be evaluated as a condition within join.
    */
   protected def canEvaluateWithinJoin(expr: Expression): Boolean = expr match {
-    case l: ListQuery => false
+    case l: ListQuery =>
+      // Now pulling up IN predicates is deferred to `RewritePredicateSubquery`. As a result,
+      // `ListQuery`'s children can be empty before that rule and falls into the next case.
+      false
     case e: SubqueryExpression =>
       // non-correlated subquery will be replaced as literal
       e.children.isEmpty