add TODOs

apache · May 6, 2015 · 6af181f · 6af181f
1 parent 8285134
commit 6af181f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala b/mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala
@@ -122,6 +122,7 @@ class CrossValidator extends Estimator[CrossValidatorModel] with CrossValidatorP
       trainingDataset.unpersist()
       var i = 0
       while (i < numModels) {
+        // TODO: duplicate evaluator to take extra params from input
         val metric = eval.evaluate(models(i).transform(validationDataset, epm(i)))
         logDebug(s"Got metric $metric for model trained with ${epm(i)}.")
         metrics(i) += metric

diff --git a/python/pyspark/ml/tuning.py b/python/pyspark/ml/tuning.py
@@ -224,6 +224,7 @@ def fit(self, dataset, params={}):
             train = df.filter(~condition)
             for j in range(numModels):
                 model = est.fit(train, epm[j])
+                # TODO: duplicate evaluator to take extra params from input
                 metric = eva.evaluate(model.transform(validation, epm[j]))
                 metrics[j] += metric
         bestIndex = np.argmax(metrics)