On wenchen's comment

apache · Aug 24, 2016 · 7e7cb85 · 7e7cb85
1 parent 8c8bd9a
commit 7e7cb85
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala b/...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
@@ -523,8 +523,6 @@ abstract class TypedImperativeAggregate[T] extends ImperativeAggregate {
   /**
    * In-place replaces the aggregation buffer object stored at buffer's index
    * `mutableAggBufferOffset`, with SparkSQL internally supported underlying storage format.
-   *
-   * The framework calls this method every time after updating/merging one group (group by key).
    */
   final def serializeAggregateBufferInPlace(buffer: MutableRow): Unit = {
     val bufferObject = getField[T](buffer, mutableAggBufferOffset)

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/TypedImperativeAggregateSuite.scala
@@ -73,11 +73,9 @@ class TypedImperativeAggregateSuite extends QueryTest with SharedSQLContext {
   test("supports SpecificMutableRow as mutable row") {
     val aggregationBufferSchema = Seq(IntegerType, LongType, BinaryType, IntegerType)
     val aggBufferOffset = 2
-    val inputBufferObject = 1
     val buffer = new SpecificMutableRow(aggregationBufferSchema)
-    val agg = new TypedMax(BoundReference(inputBufferObject, IntegerType, nullable = false))
+    val agg = new TypedMax(BoundReference(ordinal = 1, dataType = IntegerType, nullable = false))
       .withNewMutableAggBufferOffset(aggBufferOffset)
-      .withNewInputAggBufferOffset(inputBufferObject)
 
     agg.initialize(buffer)
     data.foreach { kv =>
@@ -222,7 +220,7 @@ object TypedImperativeAggregateSuite {
           if (inputValue > buffer.value) {
             buffer.value = inputValue
           }
-        case null => buffer
+        case null => // skip
       }
     }