Skip to content

Commit

Permalink
[SPARK-26198][SQL] Fix Metadata serialize null values throw NPE
Browse files Browse the repository at this point in the history
How to reproduce this issue:
```scala
scala> val meta = new org.apache.spark.sql.types.MetadataBuilder().putNull("key").build().json
java.lang.NullPointerException
  at org.apache.spark.sql.types.Metadata$.org$apache$spark$sql$types$Metadata$$toJsonValue(Metadata.scala:196)
  at org.apache.spark.sql.types.Metadata$$anonfun$1.apply(Metadata.scala:180)
```

This pr fix `NullPointerException` when `Metadata` serialize `null` values.

unit tests

Closes #23164 from wangyum/SPARK-26198.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 676bbb2)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
  • Loading branch information
wangyum authored and srowen committed Dec 3, 2018
1 parent 0058986 commit 8236f64
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ object Metadata {
JBool(x)
case x: String =>
JString(x)
case null =>
JNull
case x: Metadata =>
toJsonValue(x.map)
case other =>
Expand Down

0 comments on commit 8236f64

Please sign in to comment.