CR feedback

apache · Apr 8, 2014 · aa95083 · aa95083
1 parent 7752594
commit aa95083
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/core/src/main/scala/org/apache/spark/executor/ExecutorURLClassLoader.scala b/core/src/main/scala/org/apache/spark/executor/ExecutorURLClassLoader.scala
@@ -26,15 +26,15 @@ import org.apache.spark.util.ParentClassLoader
  * We also make changes so user classes can come before the default classes.
  */
 
-trait AddableURLClassLoader extends ClassLoader {
+private[spark] trait MutableURLClassLoader extends ClassLoader {
   def addURL(url: URL)
-  def getURLs(): Array[URL]
+  def getURLs: Array[URL]
 }
 
 private[spark] class ChildExecutorURLClassLoader(urls: Array[URL], parent: ClassLoader)
   extends ClassLoader with AddableURLClassLoader {
 
-  object userClassLoader extends URLClassLoader(urls, null){
+  private val userClassLoader = new URLClassLoader(urls, null){
     override def addURL(url: URL) {
       super.addURL(url)
     }
@@ -43,7 +43,7 @@ private[spark] class ChildExecutorURLClassLoader(urls: Array[URL], parent: Class
     }
   }
 
-  val parentClassLoader = new ParentClassLoader(parent)
+  private val parentClassLoader = new ParentClassLoader(parent)
 
   override def findClass(name: String): Class[_] = {
     try {