fix code style

apache · Dec 23, 2014 · c6a6e3e · c6a6e3e
1 parent 3214e0a
commit c6a6e3e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
@@ -361,7 +361,6 @@ trait HiveTypeCoercion {
           DecimalType(min(p1 - s1, p2 - s2) + max(s1, s2), max(s1, s2))
         )
 
-      // Cast is not needed for binary comparison
       case LessThan(e1 @ DecimalType.Expression(p1, s1),
           e2 @ DecimalType.Expression(p2, s2)) if p1 != p2 || s1 != s2 =>
         LessThan(Cast(e1, DecimalType.Unlimited), Cast(e2, DecimalType.Unlimited))

diff --git a/...atalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala b/...atalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecisionSuite.scala
@@ -50,10 +50,12 @@ class DecimalPrecisionSuite extends FunSuite with BeforeAndAfter {
   }
 
   private def checkComparison(expression: Expression, expectedType: DataType): Unit = {
-    val plan = Project(Seq(Alias(expression, "c")()), relation)
-    val comparison = analyzer(plan).expressions(0).children(0).asInstanceOf[BinaryComparison]
-    assert(comparison.left.dataType ===  expectedType)
-    assert(comparison.right.dataType ===  expectedType)
+    val plan = Project(Alias(expression, "c")() :: Nil, relation)
+    val comparison = analyzer(plan).collect {
+      case Project(Alias(e: BinaryComparison, _) :: Nil, _) => e
+    }.head
+    assert(comparison.left.dataType === expectedType)
+    assert(comparison.right.dataType === expectedType)
   }
 
   test("basic operations") {