-
Notifications
You must be signed in to change notification settings - Fork 28.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-44154][SQL] Added more unit tests to BitmapExpressionUtilsSuit…
…e and made minor improvements to Bitmap Aggregate Expressions ### What changes were proposed in this pull request? I firstly added more unit tests for the `BITMAT_BIT_POSITION` and `BITMAP_BUCKET_NUMBER` expressions. Secondly, I made a minor improvement in the implementation of the `BITMAP_CONSTRUCT_AGG` and `BUTMAP_OR_AGG` expressions, where I converted `inputAggBufferAttributes` from a method to a value. ### Why are the changes needed? The unit tests cover more corner cases. Having `inputAggBufferAttributes` as a value makes it so that the AttributeReferences aren't reinitialized every time `inputAggBufferAttributes` is referred to. ### How was this patch tested? I reran all the tests for Bitmap expressions and they succeeded. The test suites were `BitmapExpressionUtilsSuite` and `BitmapExpressionsQuerySuite`. Closes #42043 from harshmotw-db/harsh-dev. Authored-by: Harsh Motwani <harsh.motwani@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
- Loading branch information
1 parent
228b5db
commit df550cf
Showing
2 changed files
with
19 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters