Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
szehon-ho committed Jun 8, 2024
1 parent 36a8a92 commit e7f0ec0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ case class TransformExpression(
override protected def withNewChildrenInternal(newChildren: IndexedSeq[Expression]): Expression =
copy(children = newChildren)

lazy val resolvedFunction: Option[Expression] = this match {
private lazy val resolvedFunction: Option[Expression] = this match {
case TransformExpression(scalarFunc: ScalarFunction[_], arguments, Some(numBuckets)) =>
Some(V2ExpressionUtils.resolveScalarFunction(scalarFunc,
Seq(Literal(numBuckets)) ++ arguments))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ case class KeyGroupedShuffleSpec(


override def createPartitioning(clustering: Seq[Expression]): Partitioning = {
val newExpressions: Seq[Expression] = clustering.zip(partitioning.expressions).map{
val newExpressions: Seq[Expression] = clustering.zip(partitioning.expressions).map {
case (c, e: TransformExpression) => TransformExpression(
e.function, Seq(c), e.numBucketsOpt)
case (c, _) => c
Expand Down

0 comments on commit e7f0ec0

Please sign in to comment.