Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12132] [PYSPARK] raise KeyboardInterrupt inside SIGINT handler #10134

Closed
wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Dec 3, 2015

Currently, the current line is not cleared by Cltr-C

After this patch

>>> asdfasdf^C
Traceback (most recent call last):
  File "~/spark/python/pyspark/context.py", line 225, in signal_handler
    raise KeyboardInterrupt()
KeyboardInterrupt

It's still worse than 1.5 (and before).

@mkman84
Copy link

mkman84 commented Dec 3, 2015

Thanks @davies ! It is indeed still worse than 1.5, since it didn't throw the traceback in, but at least it's better than having to delete everything on the current line or worse, hit enter and accidentally execute some code in the shell that wasn't intended! Perhaps that can just be cleaned up in 1.6.1? Or I'll just look into a clean way to fix this

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47154 has finished for PR 10134 at commit fd9cd0d.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 4, 2015

Test build #2166 has finished for PR 10134 at commit fd9cd0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class CrossValidator @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String)\n * class ParamGridBuilder @Since(\"1.2.0\")\n * class TrainValidationSplit @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n

asfgit pushed a commit that referenced this pull request Dec 7, 2015
Currently, the current line is not cleared by Cltr-C

After this patch
```
>>> asdfasdf^C
Traceback (most recent call last):
  File "~/spark/python/pyspark/context.py", line 225, in signal_handler
    raise KeyboardInterrupt()
KeyboardInterrupt
```

It's still worse than 1.5 (and before).

Author: Davies Liu <davies@databricks.com>

Closes #10134 from davies/fix_cltrc.

(cherry picked from commit ef3f047)
Signed-off-by: Davies Liu <davies.liu@gmail.com>
@asfgit asfgit closed this in ef3f047 Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants