[SPARK-12188] [SQL] Code refactoring and comment correction in Dataset APIs #10184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Test build #47298 has finished for PR 10184 at commit
|
|
Test build #47300 has finished for PR 10184 at commit
|
|
|
||
| /** | ||
| * The encoder where the expressions used to construct an object from an input row have been | ||
| * bound to the ordinals of the given schema. |
There was a problem hiding this comment.
Nit: I'm going to change this to say this [[Dataset]]'s output schema
There was a problem hiding this comment.
Let me add the change in a follow-up PR. : )
|
Thanks, I'm going to merge this to master and 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2015
… APIs This PR contains the following updates: - Created a new private variable `boundTEncoder` that can be shared by multiple functions, `RDD`, `select` and `collect`. - Replaced all the `queryExecution.analyzed` by the function call `logicalPlan` - A few API comments are using wrong class names (e.g., `DataFrame`) or parameter names (e.g., `n`) - A few API descriptions are wrong. (e.g., `mapPartitions`) marmbrus rxin cloud-fan Could you take a look and check if they are appropriate? Thank you! Author: gatorsmile <gatorsmile@gmail.com> Closes #10184 from gatorsmile/datasetClean. (cherry picked from commit 5d96a71) Signed-off-by: Michael Armbrust <michael@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
boundTEncoderthat can be shared by multiple functions,RDD,selectandcollect.queryExecution.analyzedby the function calllogicalPlanDataFrame) or parameter names (e.g.,n)mapPartitions)@marmbrus @rxin @cloud-fan Could you take a look and check if they are appropriate? Thank you!