Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-12199][DOC] Follow-up: Refine example code in ml-features.md #10193

Closed
wants to merge 4 commits into from

Conversation

yinxusen
Copy link
Contributor

@yinxusen yinxusen commented Dec 8, 2015

https://issues.apache.org/jira/browse/SPARK-12199

Follow-up PR of SPARK-11551. Fix some errors in ml-features.md

@mengxr

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47322 has finished for PR 10193 at commit 5848881.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Dec 8, 2015

@yinxusen Could you fix conflicts? Thanks!

@yinxusen
Copy link
Contributor Author

yinxusen commented Dec 9, 2015

@mengxr The conflict is caused by the revert of #10002, for unchecking of Python style. I think we need to wait for that PR being merged. I have sent a PR to @somideshmukh and hope he could merge it ASAP.

@mengxr
Copy link
Contributor

mengxr commented Dec 9, 2015

test it please

@yinxusen
Copy link
Contributor Author

retest it please

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47457 has finished for PR 10193 at commit 3630cc6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaBinarizerExample\n * public class JavaBucketizerExample\n * public class JavaDCTExample\n * public class JavaElementwiseProductExample\n * public class JavaMinMaxScalerExample\n * public class JavaNGramExample\n * public class JavaNormalizerExample\n * public class JavaOneHotEncoderExample\n * public class JavaPCAExample\n * public class JavaPolynomialExpansionExample\n * public class JavaRFormulaExample\n * public class JavaStandardScalerExample\n * public class JavaStopWordsRemoverExample\n * public class JavaStringIndexerExample\n * public class JavaTokenizerExample\n * public class JavaVectorAssemblerExample\n * public class JavaVectorIndexerExample\n * public class JavaVectorSlicerExample\n

@yinxusen
Copy link
Contributor Author

@mengxr Does it look good to you? :)

@BenFradet
Copy link
Contributor

There is one nit in polynomial_expansion_example.py with the spaces.
Except that, it lgtm.

@BenFradet
Copy link
Contributor

Plus, there is inconsistent naming between the docs and the example file for Element[W|w]iseProductExample.scala

@yinxusen
Copy link
Contributor Author

@BenFradet All clear now. Thanks!

@yinxusen
Copy link
Contributor Author

Faint! OSX's file name is not case sensitive... that's why I miss the Element[W|w]iseProductExample.scala error.

@SparkQA
Copy link

SparkQA commented Dec 10, 2015

Test build #47493 has finished for PR 10193 at commit 51b42b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@BenFradet
Copy link
Contributor

No problem, I'm just glad it's fixed.

@BenFradet
Copy link
Contributor

Pinging @mengxr and @jkbradley as it is not currently possible to generate this doc on master.

@@ -63,7 +63,7 @@ the [IDF Python docs](api/python/pyspark.ml.html#pyspark.ml.feature.IDF) for mor
`Word2VecModel`. The model maps each word to a unique fixed-size vector. The `Word2VecModel`
transforms each document into a vector using the average of all words in the document; this vector
can then be used for as features for prediction, document similarity calculations, etc.
Please refer to the [MLlib user guide on Word2Vec](mllib-feature-extraction.html#Word2Vec) for more
Please refer to the [MLlib user guide on Word2Vec](mllib-feature-extraction.html#word2Vec) for more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "V" in "word2vec" in the link should be lowercase

@jkbradley
Copy link
Member

I'll make sure this gets in. Just had 1 comment (and trying to generate the docs locally now)

@jkbradley
Copy link
Member

OK, it worked locally. This should be fine after that final comment.

@SparkQA
Copy link

SparkQA commented Dec 13, 2015

Test build #2213 has finished for PR 10193 at commit 51b42b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Since this is a problem for the release, I'll go ahead and merge this with master and branch-1.6. @yinxusen Could you please send a follow-up to fix the broken link? Thanks!

asfgit pushed a commit that referenced this pull request Dec 13, 2015
https://issues.apache.org/jira/browse/SPARK-12199

Follow-up PR of SPARK-11551. Fix some errors in ml-features.md

mengxr

Author: Xusen Yin <yinxusen@gmail.com>

Closes #10193 from yinxusen/SPARK-12199.

(cherry picked from commit 98b212d)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 98b212d Dec 13, 2015
asfgit pushed a commit that referenced this pull request Dec 14, 2015
Follow-up of [SPARK-12199](https://issues.apache.org/jira/browse/SPARK-12199) and #10193 where a broken link has been left as is.

Author: BenFradet <benjamin.fradet@gmail.com>

Closes #10282 from BenFradet/SPARK-12199.

(cherry picked from commit e25f1fe)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request Dec 14, 2015
Follow-up of [SPARK-12199](https://issues.apache.org/jira/browse/SPARK-12199) and #10193 where a broken link has been left as is.

Author: BenFradet <benjamin.fradet@gmail.com>

Closes #10282 from BenFradet/SPARK-12199.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants