-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12199][DOC] Follow-up: Refine example code in ml-features.md #10193
Conversation
Test build #47322 has finished for PR 10193 at commit
|
@yinxusen Could you fix conflicts? Thanks! |
@mengxr The conflict is caused by the revert of #10002, for unchecking of Python style. I think we need to wait for that PR being merged. I have sent a PR to @somideshmukh and hope he could merge it ASAP. |
test it please |
retest it please |
Test build #47457 has finished for PR 10193 at commit
|
@mengxr Does it look good to you? :) |
There is one nit in polynomial_expansion_example.py with the spaces. |
Plus, there is inconsistent naming between the docs and the example file for Element[W|w]iseProductExample.scala |
@BenFradet All clear now. Thanks! |
Faint! OSX's file name is not case sensitive... that's why I miss the Element[W|w]iseProductExample.scala error. |
Test build #47493 has finished for PR 10193 at commit
|
No problem, I'm just glad it's fixed. |
Pinging @mengxr and @jkbradley as it is not currently possible to generate this doc on master. |
@@ -63,7 +63,7 @@ the [IDF Python docs](api/python/pyspark.ml.html#pyspark.ml.feature.IDF) for mor | |||
`Word2VecModel`. The model maps each word to a unique fixed-size vector. The `Word2VecModel` | |||
transforms each document into a vector using the average of all words in the document; this vector | |||
can then be used for as features for prediction, document similarity calculations, etc. | |||
Please refer to the [MLlib user guide on Word2Vec](mllib-feature-extraction.html#Word2Vec) for more | |||
Please refer to the [MLlib user guide on Word2Vec](mllib-feature-extraction.html#word2Vec) for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "V" in "word2vec" in the link should be lowercase
I'll make sure this gets in. Just had 1 comment (and trying to generate the docs locally now) |
OK, it worked locally. This should be fine after that final comment. |
Test build #2213 has finished for PR 10193 at commit
|
Since this is a problem for the release, I'll go ahead and merge this with master and branch-1.6. @yinxusen Could you please send a follow-up to fix the broken link? Thanks! |
https://issues.apache.org/jira/browse/SPARK-12199 Follow-up PR of SPARK-11551. Fix some errors in ml-features.md mengxr Author: Xusen Yin <yinxusen@gmail.com> Closes #10193 from yinxusen/SPARK-12199. (cherry picked from commit 98b212d) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Follow-up of [SPARK-12199](https://issues.apache.org/jira/browse/SPARK-12199) and #10193 where a broken link has been left as is. Author: BenFradet <benjamin.fradet@gmail.com> Closes #10282 from BenFradet/SPARK-12199. (cherry picked from commit e25f1fe) Signed-off-by: Sean Owen <sowen@cloudera.com>
Follow-up of [SPARK-12199](https://issues.apache.org/jira/browse/SPARK-12199) and #10193 where a broken link has been left as is. Author: BenFradet <benjamin.fradet@gmail.com> Closes #10282 from BenFradet/SPARK-12199.
https://issues.apache.org/jira/browse/SPARK-12199
Follow-up PR of SPARK-11551. Fix some errors in ml-features.md
@mengxr