-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-8517][ML][DOC] Reorganizes the spark.ml user guide #10207
Conversation
I'd use the "[ML]" tag in the PR title. |
Remove the empty "ml-pipelines.md" file? |
Test build #47358 has finished for PR 10207 at commit
|
- text: Feature extraction, transformation, and selection | ||
- text: "Overview: estimators, transformers and pipelines" | ||
url: ml-intro.html | ||
- text: Building and transforming features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like using the keywords "extraction, transformation, and selection" since users may search for those. "Building" is pretty generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Remove empty "ml-examples.md" file? |
Those are my high-level comments. Have you rewritten much text? If so, I can do a second more detailed pass after updates (which will require restructuring). Thanks! |
@jkbradley no this PR just moves the text around, with little modification. More substantital changes will be done later. |
OK thanks just confirming |
Test build #47367 has finished for PR 10207 at commit
|
Test build #47369 has finished for PR 10207 at commit
|
For more background and more details about the implementation, refer to the documentation of the [logistic regression in `spark.mllib`](mllib-linear-methods.html#logistic-regression). | ||
|
||
> The current implementation of logistic regression in `spark.ml` only supports binary classes. Support for multiclass regression will be added in the future. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use "Example" heading
Thanks! just a few comments |
Thanks for updating it! LGTM pending tests. |
Test build #2187 has finished for PR 10207 at commit
|
Test build #47384 has finished for PR 10207 at commit
|
Merging with master and branch-1.6 |
This PR moves pieces of the spark.ml user guide to reflect suggestions in SPARK-8517. It does not introduce new content, as requested. <img width="192" alt="screen shot 2015-12-08 at 11 36 00 am" src="https://cloud.githubusercontent.com/assets/7594753/11666166/e82b84f2-9d9f-11e5-8904-e215424d8444.png"> Author: Timothy Hunter <timhunter@databricks.com> Closes #10207 from thunterdb/spark-8517. (cherry picked from commit 765c67f) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
…rk.mllib and mllib in the documentation. Replaces a number of occurences of `MLlib` in the documentation that were meant to refer to the `spark.mllib` package instead. It should clarify for new users the difference between `spark.mllib` (the package) and MLlib (the umbrella project for ML in spark). It also removes some files that I forgot to delete with #10207 Author: Timothy Hunter <timhunter@databricks.com> Closes #10234 from thunterdb/12212. (cherry picked from commit 2ecbe02) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
…rk.mllib and mllib in the documentation. Replaces a number of occurences of `MLlib` in the documentation that were meant to refer to the `spark.mllib` package instead. It should clarify for new users the difference between `spark.mllib` (the package) and MLlib (the umbrella project for ML in spark). It also removes some files that I forgot to delete with #10207 Author: Timothy Hunter <timhunter@databricks.com> Closes #10234 from thunterdb/12212.
This PR moves pieces of the spark.ml user guide to reflect suggestions in SPARK-8517. It does not introduce new content, as requested.