[SPARK-13298][Core][UI]Escape "label" to avoid DAG being broken by some special character #11309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andrewor14 |
|
LGTM |
|
retest this please |
| @@ -20,10 +20,11 @@ package org.apache.spark.ui.scope | |||
| import scala.collection.mutable | |||
| import scala.collection.mutable.{ListBuffer, StringBuilder} | |||
|
|
|||
| import org.apache.commons.lang.StringEscapeUtils | |||
There was a problem hiding this comment.
Don't use anything from commons.lang; use commons.lang3.
There was a problem hiding this comment.
Hey, we should add a style-checker rule to ban the commons.lang import.
|
retest this please |
1 similar comment
|
retest this please |
|
Test build #51691 has finished for PR 11309 at commit
|
|
Merged into master and 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Feb 23, 2016
…ome special character ## What changes were proposed in this pull request? When there are some special characters (e.g., `"`, `\`) in `label`, DAG will be broken. This patch just escapes `label` to avoid DAG being broken by some special characters ## How was the this patch tested? Jenkins tests Author: Shixiong Zhu <shixiong@databricks.com> Closes #11309 from zsxwing/SPARK-13298. (cherry picked from commit a11b399) Signed-off-by: Andrew Or <andrew@databricks.com>
|
Test build #51698 has finished for PR 11309 at commit
|
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Mar 9, 2016
When generating Graphviz DOT files in the SQL query visualization we need to escape double-quotes inside node labels. This is a followup to apache#11309, which fixed a similar graph in Spark Core's DAG visualization. Author: Josh Rosen <joshrosen@databricks.com> Closes apache#11587 from JoshRosen/graphviz-escaping.
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2016
When generating Graphviz DOT files in the SQL query visualization we need to escape double-quotes inside node labels. This is a followup to #11309, which fixed a similar graph in Spark Core's DAG visualization. Author: Josh Rosen <joshrosen@databricks.com> Closes #11587 from JoshRosen/graphviz-escaping. (cherry picked from commit 81f54ac) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
When generating Graphviz DOT files in the SQL query visualization we need to escape double-quotes inside node labels. This is a followup to apache#11309, which fixed a similar graph in Spark Core's DAG visualization. Author: Josh Rosen <joshrosen@databricks.com> Closes apache#11587 from JoshRosen/graphviz-escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When there are some special characters (e.g.,
",\) inlabel, DAG will be broken. This patch just escapeslabelto avoid DAG being broken by some special charactersHow was the this patch tested?
Jenkins tests