-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13584][SQL][Tests]Make ContinuousQueryManagerSuite not output logs to the console #11439
[SPARK-13584][SQL][Tests]Make ContinuousQueryManagerSuite not output logs to the console #11439
Conversation
@@ -23,6 +23,7 @@ log4j.appender.CA=org.apache.log4j.ConsoleAppender | |||
log4j.appender.CA.layout=org.apache.log4j.PatternLayout | |||
log4j.appender.CA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %p %c: %m%n | |||
log4j.appender.CA.Threshold = WARN | |||
log4j.appender.CA.follow = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test build #52204 has finished for PR 11439 at commit
|
cc @marmbrus for quick reviewing this small patch. |
* System.out or System.err. Otherwise, ConsoleAppender will still output to the console even if | ||
* we change System.out and System.err. | ||
*/ | ||
private def testQuietly(name: String)(f: => Unit): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should put this somewhere more general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to SQLTestUtils
LGTM |
Test build #52409 has finished for PR 11439 at commit
|
Merging to master. Thanks, @marmbrus |
… logs to the console ## What changes were proposed in this pull request? Make ContinuousQueryManagerSuite not output logs to the console. The logs will still output to `unit-tests.log`. I also updated `SQLListenerMemoryLeakSuite` to use `quietly` to avoid changing the log level which won't output logs to `unit-tests.log`. ## How was this patch tested? Just check Jenkins output. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#11439 from zsxwing/quietly-ContinuousQueryManagerSuite.
What changes were proposed in this pull request?
Make ContinuousQueryManagerSuite not output logs to the console. The logs will still output to
unit-tests.log
.I also updated
SQLListenerMemoryLeakSuite
to usequietly
to avoid changing the log level which won't output logs tounit-tests.log
.How was this patch tested?
Just check Jenkins output.