-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13599] [BUILD] remove transitive groovy dependencies from spark-hive and spark-hiveserver (branch 1.6) #11473
Conversation
Test build #52327 has finished for PR 11473 at commit
|
As I asked in #11449 -- what's the reason to justify backporting this? Usually we don't do dependency changes in a maintenance release. |
Can you update the pull request description? The current one isn't great as is. |
@steveloughran if you'll update this to match #11449 (it has to have dependncy files update to pass) I'll merge |
will do |
Test build #52554 has finished for PR 11473 at commit
|
OK it's merged. You can close this PR manually now. |
…-hive and spark-hiveserver (branch 1.6) ## What changes were proposed in this pull request? This is just the patch of #11449 cherry picked to branch-1.6; the enforcer and dep/ diffs are cut Modifies the dependency declarations of the all the hive artifacts, to explicitly exclude the groovy-all JAR. This stops the groovy classes *and everything else in that uber-JAR* from getting into spark-assembly JAR. ## How was this patch tested? 1. Pre-patch build was made: `mvn clean install -Pyarn,hive,hive-thriftserver` 1. spark-assembly expanded, observed to have the org.codehaus.groovy packages and JARs 1. A maven dependency tree was created `mvn dependency:tree -Pyarn,hive,hive-thriftserver -Dverbose > target/dependencies.txt` 1. This text file examined to confirm that groovy was being imported as a dependency of `org.spark-project.hive` 1. Patch applied 1. Repeated step1: clean build of project with ` -Pyarn,hive,hive-thriftserver` set 1. Examined created spark-assembly, verified no org.codehaus packages 1. Verified that the maven dependency tree no longer references groovy The `master` version updates the dependency files and an enforcer rule to keep groovy out; this patch strips it out. Author: Steve Loughran <stevel@hortonworks.com> Closes #11473 from steveloughran/fixes/SPARK-13599-groovy+branch-1.6.
What changes were proposed in this pull request?
This is just the patch of #11449 cherry picked to branch-1.6; the enforcer and dep/ diffs are cut
Modifies the dependency declarations of the all the hive artifacts, to explicitly exclude the groovy-all JAR.
This stops the groovy classes and everything else in that uber-JAR from getting into spark-assembly JAR.
How was this patch tested?
mvn clean install -Pyarn,hive,hive-thriftserver
mvn dependency:tree -Pyarn,hive,hive-thriftserver -Dverbose > target/dependencies.txt
org.spark-project.hive
-Pyarn,hive,hive-thriftserver
setThe
master
version updates the dependency files and an enforcer rule to keep groovy out; this patch strips it out.