[SPARK-13646] [MLlib] QuantileDiscretizer counts dataset twice in get… #11491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test this please |
|
Test build #52392 has finished for PR 11491 at commit
|
|
I'm not sure why the *scala style tests" fails. |
|
It's in the test output -- stray space before the comma :) |
|
Ok, sorry this is my first PR. Should I correct, push and pr again ? |
|
Yes just push a tiny commit to the same branch |
|
Done ! |
|
Jenkins, retest this please |
|
Test build #52413 has finished for PR 11491 at commit
|
|
Now that the tests passed. How can this be merged ? |
|
Things may take a day or more to get a response given workloads and timezones. I often leave things open a couple days just to see if there are comments. This is so straightforward that I'm comfortable merging it. |
|
Merged to master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? It avoids counting the dataframe twice. Author: Abou Haydar Elias <abouhaydar.elias@gmail.com> Author: Elie A <abouhaydar.elias@gmail.com> Closes apache#11491 from eliasah/quantile-discretizer-patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It avoids counting the dataframe twice.