-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13676] Fix mismatched default values for regParam in LogisticRegression #11519
Conversation
Jenkins test this please |
Sounds good. If you have a moment would be good to look over other default regularization params to see if there are other mismatches. |
Test build #52464 has finished for PR 11519 at commit
|
Merged into master. Thanks! |
Also, thank you for Coverity, @srowen ! |
Hi, @srowen .
However, I found that Thank you, @srowen . |
Here is the JIRA Issue SPARK-13686 and PR. |
…egression ## What changes were proposed in this pull request? The default value of regularization parameter for `LogisticRegression` algorithm is different in Scala and Python. We should provide the same value. **Scala** ``` scala> new org.apache.spark.ml.classification.LogisticRegression().getRegParam res0: Double = 0.0 ``` **Python** ``` >>> from pyspark.ml.classification import LogisticRegression >>> LogisticRegression().getRegParam() 0.1 ``` ## How was this patch tested? manual. Check the following in `pyspark`. ``` >>> from pyspark.ml.classification import LogisticRegression >>> LogisticRegression().getRegParam() 0.0 ``` Author: Dongjoon Hyun <dongjoon@apache.org> Closes apache#11519 from dongjoon-hyun/SPARK-13676.
What changes were proposed in this pull request?
The default value of regularization parameter for
LogisticRegression
algorithm is different in Scala and Python. We should provide the same value.Scala
Python
How was this patch tested?
manual. Check the following in
pyspark
.