-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13972][SQ] hive tests should fail if SQL generation failed #11782
Conversation
cc @liancheng @yhuai |
Test build #53428 has finished for PR 11782 at commit
|
@cloud-fan Let's mark this PR as WIP and use this branch to fix detected SQL generation failures. I'll open PRs directly to this branch. |
Once we have gong through the failed tests, can we make a summary (on root causes of failed tests)? |
retest this please |
Test build #53524 has finished for PR 11782 at commit
|
retest this please |
Test build #53535 has finished for PR 11782 at commit
|
retest this please |
Test build #53538 has finished for PR 11782 at commit
|
Merging to master. |
## What changes were proposed in this pull request? Now we should be able to convert all logical plans to SQL string, if they are parsed from hive query. This PR changes the error handling to throw exceptions instead of just log. We will send new PRs for spotted bugs, and merge this one after all bugs are fixed. ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#11782 from cloud-fan/test.
What changes were proposed in this pull request?
Now we should be able to convert all logical plans to SQL string, if they are parsed from hive query. This PR changes the error handling to throw exceptions instead of just log.
We will send new PRs for spotted bugs, and merge this one after all bugs are fixed.
How was this patch tested?
existing tests.