[SPARK-14410][SQL] Push functions existence check into catalog #12198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55089 has finished for PR 12198 at commit
|
andrewor14
force-pushed
the
function-exists
branch
from
bfd8d5f
to
6abe10b
Compare
|
Test build #55093 has finished for PR 12198 at commit
|
|
Test build #55146 has finished for PR 12198 at commit
|
| @@ -152,6 +152,8 @@ abstract class ExternalCatalog { | |||
|
|
|||
| def getFunction(db: String, funcName: String): CatalogFunction | |||
|
|
|||
| def functionExists(db: String, funcName: String): Boolean | |||
|
LGTM. Merging to master. We will take care the exception handling in getFunctionOption with the work of https://issues.apache.org/jira/browse/SPARK-14414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to #12117 and addresses some of the TODOs introduced there. In particular, the resolution of database is now pushed into session catalog, which knows about the current database. Further, the logic for checking whether a function exists is pushed into the external catalog.
No change in functionality is expected.
How was this patch tested?
SessionCatalogSuite,DDLSuite