[SPARK-10063][SQL] Remove DirectParquetOutputCommitter #12229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @davies |
|
LGTM |
|
Test build #55182 has finished for PR 12229 at commit
|
|
Test build #55192 has finished for PR 12229 at commit
|
|
Merging in master. |
| @@ -129,16 +129,17 @@ private[sql] abstract class BaseWriterContainer( | |||
| outputWriterFactory.newInstance(path, bucketId, dataSchema, taskAttemptContext) | |||
| } catch { | |||
| case e: org.apache.hadoop.fs.FileAlreadyExistsException => | |||
| if (outputCommitter.isInstanceOf[parquet.DirectParquetOutputCommitter]) { | |||
| // Spark-11382: DirectParquetOutputCommitter is not idempotent, meaning on retry | |||
| if (outputCommitter.getClass.getName.contains("Direct")) { | |||
There was a problem hiding this comment.
this is pretty brittle/ugly. Is there any other way, such as having an interface covering commit semantics. then the code can go .isInstanceOf[NonAtomicCommitter]?
|
@rxin so it seems like (I'm in the process of migrating form Spark 1.6 to 2.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes DirectParquetOutputCommitter. This was initially created by Databricks as a faster way to write Parquet data to S3. However, given how the underlying S3 Hadoop implementation works, this committer only works when there are no failures. If there are multiple attempts of the same task (e.g. speculation or task failures or node failures), the output data can be corrupted. I don't think this performance optimization outweighs the correctness issue.
How was this patch tested?
Removed the related tests also.