[SPARK-15983][SQL] Removes FileFormat.prepareRead #13698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JIRA is down. Will create a ticket for it later. cc @rxin @cloud-fan |
|
Test build #60618 has finished for PR 13698 at commit
|
|
LGTM |
liancheng
force-pushed
the
remove-prepare-read
branch
from
6314635
to
eeb8d52
Compare
liancheng
changed the title
|
Test build #60635 has finished for PR 13698 at commit
|
|
thanks, merging to master/2.0! |
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
## What changes were proposed in this pull request? Interface method `FileFormat.prepareRead()` was added in #12088 to handle a special case in the LibSVM data source. However, the semantics of this interface method isn't intuitive: it returns a modified version of the data source options map. Considering that the LibSVM case can be easily handled using schema metadata inside `inferSchema`, we can remove this interface method to keep the `FileFormat` interface clean. ## How was this patch tested? Existing tests. Author: Cheng Lian <lian@databricks.com> Closes #13698 from liancheng/remove-prepare-read. (cherry picked from commit 9ea0d5e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Interface method
FileFormat.prepareRead()was added in #12088 to handle a special case in the LibSVM data source.However, the semantics of this interface method isn't intuitive: it returns a modified version of the data source options map. Considering that the LibSVM case can be easily handled using schema metadata inside
inferSchema, we can remove this interface method to keep theFileFormatinterface clean.How was this patch tested?
Existing tests.