Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2580] [PySpark] keep silent in worker if JVM close the socket #1625

Closed
wants to merge 2 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Jul 29, 2014

During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

@SparkQA
Copy link

SparkQA commented Jul 29, 2014

QA tests have started for PR 1625. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17321/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 29, 2014

QA results for PR 1625:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17321/consoleFull

@rxin
Copy link
Contributor

rxin commented Jul 29, 2014

@JoshRosen

@SparkQA
Copy link

SparkQA commented Jul 29, 2014

QA tests have started for PR 1625. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17343/consoleFull

@JoshRosen
Copy link
Contributor

I've merged this into master and branch-1.0. Thanks Davies!

@davies
Copy link
Contributor Author

davies commented Jul 29, 2014

@JoshRosen did it include the last commit? I didn't find them in master nor branch-1.0. It's delayed?

@JoshRosen
Copy link
Contributor

@davies Yeah, it included both commits. If you check the Apache repo, you should see the commits, but the GitHub mirroring is currently lagging behind.

@SparkQA
Copy link

SparkQA commented Jul 29, 2014

QA results for PR 1625:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17343/consoleFull

@mattf
Copy link
Contributor

mattf commented Jul 29, 2014

+1 lgtm, validated

@asfgit asfgit closed this in ccd5ab5 Jul 29, 2014
asfgit pushed a commit that referenced this pull request Jul 29, 2014
During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

Author: Davies Liu <davies.liu@gmail.com>

Closes #1625 from davies/error and squashes the following commits:

4fbcc6d [Davies Liu] disable log4j during testing when exception is expected.
cc14202 [Davies Liu] keep silent in worker if JVM close the socket

(cherry picked from commit ccd5ab5)
Signed-off-by: Josh Rosen <joshrosen@apache.org>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

Author: Davies Liu <davies.liu@gmail.com>

Closes apache#1625 from davies/error and squashes the following commits:

4fbcc6d [Davies Liu] disable log4j during testing when exception is expected.
cc14202 [Davies Liu] keep silent in worker if JVM close the socket
@davies davies deleted the error branch September 15, 2014 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants