-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-2627] [PySpark] have the build enforce PEP 8 automatically #1744
Commits on Aug 2, 2014
-
make check output style consistent
The RAT and PEP8 checks don’t print a blank line after successful runs. The scalastyle check shouldn’t either.
Configuration menu - View commit details
-
Copy full SHA for 75ad552 - Browse repository at this point
Copy the full SHA 75ad552View commit details -
[SPARK-2627] add Python linter
This guy just runs the pep8 utility on all code in the python directory, minus cloudpickle, which is a 3rd-party library.
Configuration menu - View commit details
-
Copy full SHA for 61c07b9 - Browse repository at this point
Copy the full SHA 61c07b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12440fa - Browse repository at this point
Copy the full SHA 12440faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0541ebb - Browse repository at this point
Copy the full SHA 0541ebbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 723ed39 - Browse repository at this point
Copy the full SHA 723ed39View commit details
Commits on Aug 3, 2014
-
Configuration menu - View commit details
-
Copy full SHA for beaa9ac - Browse repository at this point
Copy the full SHA beaa9acView commit details -
[SPARK-2627] miscellaneous PEP 8 fixes
Mostly done using autopep8, plus some hand fixes.
Configuration menu - View commit details
-
Copy full SHA for a31ccc4 - Browse repository at this point
Copy the full SHA a31ccc4View commit details -
*fingers crossed* I admit I’m not exactly sure how this works… Let’s see if I did the right thing.
Configuration menu - View commit details
-
Copy full SHA for 9a66cb0 - Browse repository at this point
Copy the full SHA 9a66cb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c01d4c - Browse repository at this point
Copy the full SHA 9c01d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe57ed0 - Browse repository at this point
Copy the full SHA fe57ed0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f4900b - Browse repository at this point
Copy the full SHA 6f4900bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21da538 - Browse repository at this point
Copy the full SHA 21da538View commit details -
[SPARK-2627] space out test report sections
Everything looks cramped and it’s hard to tell at a glance where sections begin. Adding a blank line between sections should fix that.
Configuration menu - View commit details
-
Copy full SHA for a1ce7ae - Browse repository at this point
Copy the full SHA a1ce7aeView commit details -
[SPARK-2627] download pep8 at runtime
See the discussion here: #1744 (comment) Get the pep8 utility at runtime so that it’s not required to be installed on the build server.
Configuration menu - View commit details
-
Copy full SHA for dffb5dd - Browse repository at this point
Copy the full SHA dffb5ddView commit details -
[SPARK-2627] check that pep8 downloaded fine
Don’t just assume curl got the file alright. Check and exit properly if there were any problems.
Configuration menu - View commit details
-
Copy full SHA for d0a83b9 - Browse repository at this point
Copy the full SHA d0a83b9View commit details
Commits on Aug 4, 2014
-
[SPARK-2627] follow Spark bash style for if blocks
“then” goes on the same line as the opening “if”.
Configuration menu - View commit details
-
Copy full SHA for aa5b4b5 - Browse repository at this point
Copy the full SHA aa5b4b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9da347f - Browse repository at this point
Copy the full SHA 9da347fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfb9f9f - Browse repository at this point
Copy the full SHA bfb9f9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b09fae2 - Browse repository at this point
Copy the full SHA b09fae2View commit details -
[SPARK-2627] use tox.ini to exclude files
No need to exclude files in the call to pep8. The tool references tox.ini for config information, so we should use that.
Configuration menu - View commit details
-
Copy full SHA for 44e3e56 - Browse repository at this point
Copy the full SHA 44e3e56View commit details -
[SPARK-2627] undo unnecessary line breaks
“Undo” unnecessary line breaks introduced by accident when I called autopep8 on the whole Python directory without setting the max line length to 100. (autopep8 defaults to 79.)
Configuration menu - View commit details
-
Copy full SHA for 91b7584 - Browse repository at this point
Copy the full SHA 91b7584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4750e - Browse repository at this point
Copy the full SHA 7b4750eView commit details -
Merge pull request #3 from apache/master
[SPARK-1687] [PySpark] fix unit tests related to pickable namedtuple
Configuration menu - View commit details
-
Copy full SHA for 6db9a44 - Browse repository at this point
Copy the full SHA 6db9a44View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf30942 - Browse repository at this point
Copy the full SHA bf30942View commit details
Commits on Aug 5, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 0e0245f - Browse repository at this point
Copy the full SHA 0e0245fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1db5314 - Browse repository at this point
Copy the full SHA 1db5314View commit details
Commits on Aug 6, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 983d963 - Browse repository at this point
Copy the full SHA 983d963View commit details -
Configuration menu - View commit details
-
Copy full SHA for 274b238 - Browse repository at this point
Copy the full SHA 274b238View commit details