-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SparkR][Doc] fix typo in vignettes #17884
Conversation
Test build #76527 has finished for PR 17884 at commit
|
I know it is legitimate but It would be worth double checking other typos too. Usually, single typo PR is not encouraged up to my knowledge given reviwing, building and merging costs. |
@HyukjinKwon Thanks for pointing this out. I will keep this in mind next time. |
This test seems flaky on AppVeyor, not sure why
|
@actuaryzhang thanks - would you have a chance to run a quick QA check on the rest of the vignettes, if you haven't already? |
@felixcheung I ran a quick QA on the vignettes and fixed some additional typos and styles. |
Test build #76534 has finished for PR 17884 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks! just one minor request
R/pkg/vignettes/sparkr-vignettes.Rmd
Outdated
@@ -405,7 +405,7 @@ result <- gapply( | |||
head(arrange(result, "max_mpg", decreasing = TRUE)) | |||
``` | |||
|
|||
Like gapply, `gapplyCollect` applies a function to each partition of a `SparkDataFrame` and collect the result back to R `data.frame`. The output of the function should be a `data.frame` but no schema is required in this case. Note that `gapplyCollect` can fail if the output of UDF run on all the partition cannot be pulled to the driver and fit in driver memory. | |||
Like gapply, `gapplyCollect` applies a function to each partition of a `SparkDataFrame` and collect the result back to R `data.frame`. The output of the function should be a `data.frame` but no schema is required in this case. Note that `gapplyCollect` can fail if the output of the UDF on all partitions cannot be pulled into the driver's memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add backtick to gapply at the beginning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -1079,19 +1079,19 @@ There are three main object classes in SparkR you may be working with. | |||
+ `sdf` stores a reference to the corresponding Spark Dataset in the Spark JVM backend. | |||
+ `env` saves the meta-information of the object such as `isCached`. | |||
|
|||
It can be created by data import methods or by transforming an existing `SparkDataFrame`. We can manipulate `SparkDataFrame` by numerous data processing functions and feed that into machine learning algorithms. | |||
It can be created by data import methods or by transforming an existing `SparkDataFrame`. We can manipulate `SparkDataFrame` by numerous data processing functions and feed that into machine learning algorithms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, does this whitespace in front of paragraph get handled properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixcheung Yes, the four spaces indicate that the text following should be aligned with the bullet point. Otherwise, it will start as a new paragraph and have the wrong indention.
You will see the difference after compiling the Rmarkdown file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! thanks
Test build #76555 has finished for PR 17884 at commit
|
merged to master/2.2 |
## What changes were proposed in this pull request? Fix typo in vignettes Author: Wayne Zhang <actuaryzhang@uber.com> Closes apache#17884 from actuaryzhang/typo.
What changes were proposed in this pull request?
Fix typo in vignettes