Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX][Streaming] Handle port collisions in flume polling test #1803

Closed
wants to merge 4 commits into from
Closed

[HOTFIX][Streaming] Handle port collisions in flume polling test #1803

wants to merge 4 commits into from

Conversation

andrewor14
Copy link
Contributor

This is failing my tests in #1777. @tdas

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1803. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18010/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1803:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18010/consoleFull

@andrewor14 andrewor14 mentioned this pull request Aug 6, 2014
Closed
@andrewor14
Tone down bind exception message
664095c
@andrewor14
Merge branch 'master' of github.com:apache/spark into fix-flaky-strea…
54a0ca0 
…ming-test
@andrewor14
Catch all exceptions caused by BindExceptions
ea11a03 
Looks like the actual exception thrown sometimes is
org.jboss.netty.channel.ChannelException: Failed to bind to:
localhost/127.0.0.1:60550, which is not a java.net.BindException.
We should catch these too.
@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1803. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18040/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1803:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18040/consoleFull

@tdas
Copy link
Contributor

tdas commented Aug 6, 2014

Jenkins, test this please.

@tdas
Copy link
Contributor

tdas commented Aug 6, 2014

LGTM, running couple of more rounds of jenkins tests to see its flakiness.

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1803. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18046/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1803:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18046/consoleFull

@andrewor14
Copy link
Contributor Author

Flume polling tests pass. Looks like we have another source of flakiness.

@andrewor14
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1803. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18067/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1803:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18067/consoleFull

@tdas
Copy link
Contributor

tdas commented Aug 6, 2014

Okay, enough testing. Merging it now.

@asfgit asfgit closed this in c6889d2 Aug 6, 2014
@andrewor14 andrewor14 deleted the fix-flaky-streaming-test branch August 11, 2014 18:46
tdas pushed a commit to tdas/spark that referenced this pull request Aug 21, 2014
@andrewor14 @tdas
[HOTFIX][Streaming] Handle port collisions in flume polling test
7e989ba 
This is failing my tests in apache#1777. @tdas

Author: Andrew Or <andrewor14@gmail.com>

Closes apache#1803 from andrewor14/fix-flaky-streaming-test and squashes the following commits:

ea11a03 [Andrew Or] Catch all exceptions caused by BindExceptions
54a0ca0 [Andrew Or] Merge branch 'master' of github.com:apache/spark into fix-flaky-streaming-test
664095c [Andrew Or] Tone down bind exception message
af3ddc9 [Andrew Or] Handle port collisions in flume polling test
asfgit pushed a commit that referenced this pull request Aug 21, 2014
@andrewor14 @tdas
[HOTFIX][Streaming] Handle port collisions in flume polling test
3f91e9d 
This is failing my tests in #1777. @tdas

Author: Andrew Or <andrewor14@gmail.com>

Closes #1803 from andrewor14/fix-flaky-streaming-test and squashes the following commits:

ea11a03 [Andrew Or] Catch all exceptions caused by BindExceptions
54a0ca0 [Andrew Or] Merge branch 'master' of github.com:apache/spark into fix-flaky-streaming-test
664095c [Andrew Or] Tone down bind exception message
af3ddc9 [Andrew Or] Handle port collisions in flume polling test
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@andrewor14 @conviva-zz
[HOTFIX][Streaming] Handle port collisions in flume polling test
2d31b6a 
This is failing my tests in apache#1777. @tdas

Author: Andrew Or <andrewor14@gmail.com>

Closes apache#1803 from andrewor14/fix-flaky-streaming-test and squashes the following commits:

ea11a03 [Andrew Or] Catch all exceptions caused by BindExceptions
54a0ca0 [Andrew Or] Merge branch 'master' of github.com:apache/spark into fix-flaky-streaming-test
664095c [Andrew Or] Tone down bind exception message
af3ddc9 [Andrew Or] Handle port collisions in flume polling test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewor14 @SparkQA @tdas