Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-2678] Follow-up commit for #1715 #1801, spark-shell is broken #1861

Closed
wants to merge 2 commits into from
Closed

[SPARK-2678] Follow-up commit for #1715 #1801, spark-shell is broken #1861

wants to merge 2 commits into from

Conversation

chutium
Copy link
Contributor

@chutium chutium commented Aug 8, 2014

all options are not working...
just run spark-shell with any options, such as --master
./bin/spark-shell --master local[2]
will get error message
bad option: '--master'

then oevr!...

more detail: #1801 (comment)

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA tests have started for PR 1861. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18228/consoleFull

@chutium
Copy link
Contributor Author

chutium commented Aug 8, 2014

maybe spark-shell.cmd should also be changed?

according to #1801 (comment)

cmd /V /E /C %SPARK_HOME%\bin\spark-submit.cmd spark-shell --class org.apache.spark.repl.Main %*

must be changed to

cmd /V /E /C %SPARK_HOME%\bin\spark-submit.cmd %* --class org.apache.spark.repl.Main spark-shell

right? spark-shell is the so called [app options] , so it should be the last augment ?

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA tests have started for PR 1861. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18229/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA results for PR 1861:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18228/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 8, 2014

QA results for PR 1861:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18229/consoleFull

asfgit pushed a commit that referenced this pull request Aug 10, 2014
@sarutak @pwendell
[SPARK-2894] spark-shell doesn't accept flags
ba223b8 
As sryza reported, spark-shell doesn't accept any flags.
The root cause is wrong usage of spark-submit in spark-shell and it come to the surface by #1801

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Author: Cheng Lian <lian.cs.zju@gmail.com>

Closes #1715, Closes #1864, and Closes #1861

Closes #1825 from sarutak/SPARK-2894 and squashes the following commits:

47f3510 [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into SPARK-2894
2c899ed [Kousuke Saruta] Removed useless code from java_gateway.py
98287ed [Kousuke Saruta] Removed useless code from java_gateway.py
513ad2e [Kousuke Saruta] Modified util.sh to enable to use option including white spaces
28a374e [Kousuke Saruta] Modified java_gateway.py to recognize arguments
5afc584 [Cheng Lian] Filter out spark-submit options when starting Python gateway
e630d19 [Cheng Lian] Fixing pyspark and spark-shell CLI options
@asfgit asfgit closed this in 4f4a988 Aug 10, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@sarutak @conviva-zz
[SPARK-2894] spark-shell doesn't accept flags
05baace 
As sryza reported, spark-shell doesn't accept any flags.
The root cause is wrong usage of spark-submit in spark-shell and it come to the surface by apache#1801

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Author: Cheng Lian <lian.cs.zju@gmail.com>

Closes apache#1715, Closes apache#1864, and Closes apache#1861

Closes apache#1825 from sarutak/SPARK-2894 and squashes the following commits:

47f3510 [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into SPARK-2894
2c899ed [Kousuke Saruta] Removed useless code from java_gateway.py
98287ed [Kousuke Saruta] Removed useless code from java_gateway.py
513ad2e [Kousuke Saruta] Modified util.sh to enable to use option including white spaces
28a374e [Kousuke Saruta] Modified java_gateway.py to recognize arguments
5afc584 [Cheng Lian] Filter out spark-submit options when starting Python gateway
e630d19 [Cheng Lian] Fixing pyspark and spark-shell CLI options
viirya pushed a commit to viirya/spark-1 that referenced this pull request Oct 19, 2023
@RussellSpitzer
rdar://115909994 Updates Iceberg to Apple 1.3.0.4 (apache#1861)
fd14b27 
https://github.pie.apple.com/IPR/apache-incubator-iceberg/compare/IPR:6607250...IPR:9a2d360

Only change is this Boson Commit
https://github.pie.apple.com/IPR/apache-incubator-iceberg/commit/7a9290b0c67ea3e50433f290ad357dff4854b803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chutium @SparkQA