Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][HIVE] Typo fixes #20550

Closed
wants to merge 1 commit into from

Conversation

jaceklaskowski
Copy link
Contributor

What changes were proposed in this pull request?

Typo fixes (with expanding a Hive property)

How was this patch tested?

local build. Awaiting Jenkins

@srowen
Copy link
Member

srowen commented Feb 8, 2018

That's fine. As usual please have a look for more if you can.

@SparkQA
Copy link

SparkQA commented Feb 8, 2018

Test build #87225 has finished for PR 20550 at commit dcbb4da.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jaceklaskowski
Copy link
Contributor Author

I'll try to add more typos from other modules. I didn't mean to "pollute" a minor change and make it bigger (and possibly questionable :))

@srowen
Copy link
Member

srowen commented Feb 9, 2018

Not sure what you mean; I think typo fixes are always logically related, and are trivial, so can easily be part of one change. For example, I skimmed with my IDE spell checker and found 40 a few weeks ago. I know there is more to do. For experienced people, we generally push back on small PRs.

@SparkQA
Copy link

SparkQA commented Feb 10, 2018

Test build #4090 has finished for PR 20550 at commit dcbb4da.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Feb 10, 2018

Merged to master/2.3

@asfgit asfgit closed this in 557938e Feb 10, 2018
asfgit pushed a commit that referenced this pull request Feb 10, 2018
## What changes were proposed in this pull request?

Typo fixes (with expanding a Hive property)

## How was this patch tested?

local build. Awaiting Jenkins

Author: Jacek Laskowski <jacek@japila.pl>

Closes #20550 from jaceklaskowski/hiveutils-typos.

(cherry picked from commit 557938e)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@jaceklaskowski jaceklaskowski deleted the hiveutils-typos branch February 11, 2018 19:51
robert3005 pushed a commit to palantir/spark that referenced this pull request Feb 12, 2018
## What changes were proposed in this pull request?

Typo fixes (with expanding a Hive property)

## How was this patch tested?

local build. Awaiting Jenkins

Author: Jacek Laskowski <jacek@japila.pl>

Closes apache#20550 from jaceklaskowski/hiveutils-typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants