-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite #21536
Conversation
Test build #91691 has finished for PR 21536 at commit
|
Hm .. ? retest this please |
Test build #91695 has finished for PR 21536 at commit
|
retest this please |
Test build #91721 has finished for PR 21536 at commit
|
retest this please |
Test build #91746 has finished for PR 21536 at commit
|
retest this please |
Test build #91753 has finished for PR 21536 at commit
|
@HyukjinKwon can we merge this? |
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged to master and branch-2.3. |
## What changes were proposed in this pull request? We don't require specific ordering of the input data, the sort action is not necessary and misleading. ## How was this patch tested? Existing test suite. Author: Xingbo Jiang <xingbo.jiang@databricks.com> Closes #21536 from jiangxb1987/sorterSuite. (cherry picked from commit 534065e) Signed-off-by: hyukjinkwon <gurwls223@apache.org>
Thanks! @HyukjinKwon |
What changes were proposed in this pull request?
We don't require specific ordering of the input data, the sort action is not necessary and misleading.
How was this patch tested?
Existing test suite.