[SPARK-24658][SQL] Remove workaround for ANTLR bug #21641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not 100% that we could remove this workaround because we hold some workarounds that are not essentially needed anymore, e.g., Anyway, in the description above, can you put the antlr version that have fixed the issue? |
|
Test build #92324 has finished for PR 21641 at commit
|
|
retest this please |
|
Test build #92327 has finished for PR 21641 at commit
|
|
Based on my understanding, the issue should be fixed by antlr/antlr4#873 , which is released in https://github.com/antlr/antlr4/releases/tag/4.5.1 |
gatorsmile
reviewed
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue antlr/antlr4#781 has already been fixed, so the workaround of extracting the pattern into a separate rule is no longer needed. The presto already removed it: prestodb/presto#10744.
How was this patch tested?
Existing tests