[SPARK-25508][SQL][TEST] Refactor OrcReadBenchmark to use main method #22580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #96743 has finished for PR 22580 at commit
|
| Seq(ByteType, ShortType, IntegerType, LongType, FloatType, DoubleType).foreach { dataType => | ||
| numericScanBenchmark(1024 * 1024 * 15, dataType) | ||
| override def benchmark(): Unit = { | ||
| runBenchmark("SQL Single Column Scan") { |
There was a problem hiding this comment.
nit SQL Single Column Scan -> SQL Single Numeric Column Scan?
There was a problem hiding this comment.
Also, please add [TEST] into the title.
yucai
changed the title
|
Test build #96782 has finished for PR 22580 at commit
|
|
retest this please |
|
Test build #96788 has finished for PR 22580 at commit
|
|
retest this please |
|
Test build #96790 has finished for PR 22580 at commit
|
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Refactor OrcReadBenchmark to use main method. Generate benchmark result: ``` SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "hive/test:runMain org.apache.spark.sql.hive.orc.OrcReadBenchmark" ``` ## How was this patch tested? manual tests Closes apache#22580 from yucai/SPARK-25508. Lead-authored-by: yucai <yyu1@ebay.com> Co-authored-by: Yucai Yu <yucai.yu@foxmail.com> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor OrcReadBenchmark to use main method.
Generate benchmark result:
How was this patch tested?
manual tests