[SPARK-25589][SQL][TEST] Add BloomFilterBenchmark #22605
Conversation
|
Test build #96834 has finished for PR 22605 at commit
|
|
Test build #96840 has finished for PR 22605 at commit
|
|
retest this please |
|
Test build #96848 has finished for PR 22605 at commit
|
|
Thanks, @HyukjinKwon ! |
|
Rebased to |
|
Test build #96861 has finished for PR 22605 at commit
|
|
Test build #96866 has finished for PR 22605 at commit
|
|
Thank you for review and approval, @HyukjinKwon . Merged to master. |
| val path = dir.getCanonicalPath | ||
|
|
||
| df.write.orc(path + "/withoutBF") | ||
| df.write.option("orc.bloom.filter.columns", "value").orc(path + "/withBF") |
There was a problem hiding this comment.
I think we should also add this ORC feature to the SQL doc.
There was a problem hiding this comment.
Sorry, but Apache ORC is an independent Apache project which has its own website and documents. We should respect that. If we introduce new ORC configuration one by one in Apache Spark website, it will eventually duplicate Apache ORC document in Apache Spark document.
We had better guide ORC fans to Apache ORC website. If something is missing there, they can file an ORC JIRA, not SPARK JIRA.
## What changes were proposed in this pull request? This PR aims to add `BloomFilterBenchmark`. For ORC data source, Apache Spark has been supporting for a long time. For Parquet data source, it's expected to be added with next Parquet release update. ## How was this patch tested? Manual. ```scala SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.BloomFilterBenchmark" ``` Closes apache#22605 from dongjoon-hyun/SPARK-25589. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR aims to add
BloomFilterBenchmark. For ORC data source, Apache Spark has been supporting for a long time. For Parquet data source, it's expected to be added with next Parquet release update.How was this patch tested?
Manual.