[SPARK-25595] Ignore corrupt Avro files if flag IGNORE_CORRUPT_FILES enabled #22611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #96850 has finished for PR 22611 at commit
|
|
Test build #96851 has finished for PR 22611 at commit
|
HyukjinKwon
reviewed
Oct 3, 2018
| files: Seq[FileStatus], | ||
| conf: Configuration, | ||
| ignoreExtension: Boolean): Schema = { | ||
| val ignoreCorruptFiles = SQLConf.get.ignoreCorruptFiles |
There was a problem hiding this comment.
How about matching it to sparkSession.sessionState.conf.ignoreCorruptFiles like other occurrences?
HyukjinKwon
reviewed
Oct 3, 2018
| if (!ignoreExtension && !path.getName.endsWith(".avro")) { | ||
| None | ||
| } else { | ||
| val in = new FsInput(path, conf) |
There was a problem hiding this comment.
Not a big deal but we can use Utils.tryiWithResource
HyukjinKwon
reviewed
Oct 3, 2018
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala
Show resolved
Hide resolved
HyukjinKwon
reviewed
Oct 3, 2018
| val corruptFile = new File(dir, "corrupt.avro") | ||
| val writer = new BufferedWriter(new FileWriter(corruptFile)) | ||
| writer.write("corrupt") | ||
| writer.close() |
HyukjinKwon
reviewed
Oct 3, 2018
| val schema = df.schema | ||
| val result = df.collect() | ||
| // Schema inference picks random readable sample file. | ||
| // Here we use a loop to eliminate randomness. |
There was a problem hiding this comment.
Actually I don't think it's randomness in this test. In this test, HDFS lists files in an alphabetical order under to the hood although it's not guaranteed as far as I know. I think the picking order here at least is deterministic.
HyukjinKwon
reviewed
Oct 3, 2018
| withTempPath { dir => | ||
| createDummyCorruptFile(dir) | ||
| val message = intercept[org.apache.spark.SparkException] { | ||
| spark.read.format("avro").load(dir.getAbsolutePath).schema |
There was a problem hiding this comment.
.schema wouldn't probably be needed.
|
Test build #96891 has finished for PR 22611 at commit
|
|
@HyukjinKwon Thanks for the review :) |
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…enabled ## What changes were proposed in this pull request? With flag `IGNORE_CORRUPT_FILES` enabled, schema inference should ignore corrupt Avro files, which is consistent with Parquet and Orc data source. ## How was this patch tested? Unit test Closes apache#22611 from gengliangwang/ignoreCorruptAvro. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
gengliangwang
added a commit
to gengliangwang/spark
that referenced
this pull request
Apr 25, 2020
…enabled ## What changes were proposed in this pull request? With flag `IGNORE_CORRUPT_FILES` enabled, schema inference should ignore corrupt Avro files, which is consistent with Parquet and Orc data source. ## How was this patch tested? Unit test Closes apache#22611 from gengliangwang/ignoreCorruptAvro. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
…enabled With flag `IGNORE_CORRUPT_FILES` enabled, schema inference should ignore corrupt Avro files, which is consistent with Parquet and Orc data source. Unit test Closes apache#22611 from gengliangwang/ignoreCorruptAvro. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org> (cherry picked from commit 928d073) RB=1517504 BUG=LIHADOOP-43202 R=fli,mshen,yezhou,edlu A=fli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With flag
IGNORE_CORRUPT_FILESenabled, schema inference should ignore corrupt Avro files, which is consistent with Parquet and Orc data source.How was this patch tested?
Unit test