-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-23886][SS] Update query status for ContinuousExecution #23095
Conversation
Test build #99056 has finished for PR 23095 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion regarding comment wording, besides that LGTM.
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryStatus.scala
Outdated
Show resolved
Hide resolved
Test build #99071 has finished for PR 23095 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
...src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
Outdated
Show resolved
Hide resolved
Test build #99192 has finished for PR 23095 at commit
|
cc @vanzin |
Looks good. I'd have chosen a shorter test name, but no biggie. Merging to master. |
## What changes were proposed in this pull request? Added query status updates to ContinuousExecution. ## How was this patch tested? Existing unit tests + added ContinuousQueryStatusAndProgressSuite. Closes apache#23095 from gaborgsomogyi/SPARK-23886. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
## What changes were proposed in this pull request? Added query status updates to ContinuousExecution. ## How was this patch tested? Existing unit tests + added ContinuousQueryStatusAndProgressSuite. Closes apache#23095 from gaborgsomogyi/SPARK-23886. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
What changes were proposed in this pull request?
Added query status updates to ContinuousExecution.
How was this patch tested?
Existing unit tests + added ContinuousQueryStatusAndProgressSuite.