-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-26286][TEST] Add MAXIMUM_PAGE_SIZE_BYTES exception bound unit test #23226
Conversation
|
||
try { | ||
new BytesToBytesMap( | ||
taskMemoryManager, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the indentation consistent. BTW this isn't a minor as well. It needs a JIRA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,I will correct this indentation and propose JIRA.
dd3b0e5
to
3a0fb2a
Compare
new BytesToBytesMap( | ||
taskMemoryManager, | ||
1, | ||
TaskMemoryManager.MAXIMUM_PAGE_SIZE_BYTES+1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E_BYTES+1
-> E_BYTES + 1
Test build #4457 has finished for PR 23226 at commit
|
Add max page size exception bounds checking test resolve conversation
3a0fb2a
to
486f2b5
Compare
retest this please |
Test build #4462 has finished for PR 23226 at commit
|
Merged to master. |
…test ## What changes were proposed in this pull request? Add MAXIMUM_PAGE_SIZE_BYTES Exception test ## How was this patch tested? Existing tests (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. Closes apache#23226 from wangjiaochun/BytesToBytesMapSuite. Authored-by: 10087686 <wang.jiaochun@zte.com.cn> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
Add MAXIMUM_PAGE_SIZE_BYTES Exception test
How was this patch tested?
Existing tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.