Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3448][SQL] Check for null in SpecificMutableRow.update #2325

Closed
wants to merge 1 commit into from

Conversation

liancheng
Copy link
Contributor

SpecificMutableRow.update doesn't check for null, and breaks existing MutableRow contract.

The tricky part here is that for performance considerations, the update method of all subclasses of MutableValue doesn't check for null and sets the null bit to false.

@SparkQA
Copy link

SparkQA commented Sep 9, 2014

QA tests have started for PR 2325 at commit 9366c44.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 9, 2014

QA tests have finished for PR 2325 at commit 9366c44.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

Thanks, I've merged this to master.

@asfgit asfgit closed this in c110614 Sep 10, 2014
@liancheng liancheng deleted the check-for-null branch September 24, 2014 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants